Conversation
|
BTW, we must certainly want better rendered thumbnails that are in a more square aspect ratio... but since the actual example may change a bit as we polish I'd rather not fret it. Best would be if we could script ourselves out of it |
georgestagg
left a comment
georgestagg
left a comment
There was a problem hiding this comment.
Looks like a great start!
There's some issues with facet plots, we might want to consider removing them from the gallery (or commenting out?) until we fix them.
Other than the merge conflict, LGTM.
| Use `PROJECT y, x TO cartesian` to flip the axes for horizontal bars: | ||
|
|
||
| ```{ggsql} | ||
| SELECT species, COUNT(*) as count FROM ggsql:penguins | ||
| GROUP BY species | ||
| VISUALISE species AS x, count AS y, species AS fill | ||
| DRAW bar | ||
| PROJECT y, x TO cartesian | ||
| LABEL | ||
| title => 'Penguin Count by Species', | ||
| x => 'Species', | ||
| y => 'Count' | ||
| ``` |
There was a problem hiding this comment.
This didn't work yet for me, but I know that's expected until the related PR merges.
| order: 6 | ||
| --- | ||
|
|
||
| Faceted plots (small multiples) split data into separate panels by one or more categorical variables. This makes it easy to compare patterns across groups. |
There was a problem hiding this comment.
These plots did not render well for me (see below), we should revisit this again before alpha release.
There was a problem hiding this comment.
Yeah, vegalite delenda est
I think we need to opt out of sizing completely for faceted plots
| LABEL | ||
| title => 'Bill Dimensions by Species', | ||
| x => 'Bill Length (mm)', | ||
| y => 'Bill Depth (mm)' |
There was a problem hiding this comment.
Also, I think axis labels might be broken in facet plots...
There was a problem hiding this comment.
hmm... that should have been fixed
There was a problem hiding this comment.
it has been fixed. Maybe it just was in main and not here
|
Not directly related to this PR, but we might want to add this to |
2 participants
This is mainly about the look and organisation. We can most certainly improve the examples included and add more. But I'd rather have this stub onthe site than the current examples page